search

Schrodinger-Hat / ImageGoNord-cli

A python client used for ImageGoNord
GNU General Public License v3.0
8 stars 3 forks source link

Change palette parameter #26

Closed BugliL closed 1 day ago

BugliL commented 3 weeks ago

To specify the palette and colors this is the actual syntax

~$ image-go-nord -i=file_1.png -o=file_output.png --nord=Aurora,PolarNight
~$ image-go-nord -i=file_1.png -o=file_output.png --monokai

I think that could be better and easier to implement and maintain this syntax:

~$ image-go-nord -i=file_1.png -o=file_output.png --palette nord --colors Aurora
~$ image-go-nord -i=file_1.png -o=file_output.png --palette nord --colors Aurora PolarNight
~$ image-go-nord -i=file_1.png -o=file_output.png --palette monokai
~$ image-go-nord -i=file_1.png -o=file_output.png -p nord -c Aurora
~$ image-go-nord -i=file_1.png -o=file_output.png -p nord -c Aurora PolarNight
~$ image-go-nord -i=file_1.png -o=file_output.png -p monokai
TheJoin95 commented 3 weeks ago

Overall, I agree. It could be useful to have also a choice interface, directly from a list.

And what happen in the case of a user is specifying more HEX colors?

Wabri commented 3 weeks ago

Yes, the first version o the cli wasn't made for several palette, now we should consider as a core feature of it.

Little typo on the leader command image-go-nord with d not with t.

Do we want to use this long version or maybe consider to shorten with something like this ign -i=... -o=...?

BugliL commented 3 weeks ago

maybe consider to shorten with something like this ign -i=... -o=... ?

I agree with it, we could do another issue for it

BugliL commented 3 weeks ago

It could be useful to have also a choice interface, directly from a list.

I think is enough the parameters, maybe, if someone misspelled the name, we could list all available palettes to show which one the user could use.