SchrodingerZhu / snmalloc-rs

rust bindings of snmalloc

MIT License

122 stars 16 forks source link

Tracking `snmalloc 2` #152

Closed SchrodingerZhu closed 1 year ago

SchrodingerZhu commented 3 years ago

@mjp41 sorry for not catching up with upstream for a while. so do we need to remove cache-friendly flag now?

mjp41 commented 3 years ago

No worries. I have a large pile of changes coming, so I haven't worried about this. Yeah, I dropped that option as it was added complexity and didn't have real benefit.

mjp41 commented 2 years ago

So most of the changes are in now. Do you think you would be able to do a beta release of the crate?

SchrodingerZhu commented 2 years ago

There was a primitive one at https://crates.io/crates/snmalloc-rs/0.3.0-beta.1+f1be609 tracking early stage snmalloc 2. I will do a dependency bump to trace latest upstream!

mjp41 commented 2 years ago

With the release of 0.6.0 it would be good to make a crate to reflect the release. I am happy to do the work, I just don't know what the work is. Could you let me know what is needed?

SchrodingerZhu commented 2 years ago

hi. sorry for the late reply. To upload a new version to crates.io：

bump upstream dependency
update versions in Cargo.toml accordingly
update readme/changelog
run cargo publish

I may also need to add your account to crates.io an maintainer.

The build logic of cc/cmake has been coupling together. I am working on implementing a separate snmalloc-src crate following the practice of https://crates.io/crates/openssl-src.

But I think it is good to do a version bump first with current code base.

Sent from ProtonMail mobile

mjp41 commented 2 years ago

167 I have attempted to follow your instructions. I haven't tried to do cargo publish yet.

mjp41 commented 2 years ago

I've created an account on crates.io linked to my GitHub profile.

SchrodingerZhu commented 2 years ago

hi, I have sent the invitation.

Sent from ProtonMail mobile

mjp41 commented 2 years ago

Thanks, could you also add me to snmalloc-sys?

SchrodingerZhu commented 2 years ago

Sure. added!

mjp41 commented 2 years ago

Awesome, I published it. Hopefully I didn't mess anything up.

@licenser interested in trying 0.3.0. It might use a little less memory and go a bit faster ;)

Licenser commented 2 years ago

Absolutely :D, this is exciting! The testing is fully automated now https://github.com/tremor-rs/tremor-runtime/pull/1708 is relevant PR (thanks dependabot!) and once it's merged the benchmarks are automatically published

mjp41 commented 2 years ago

@Licenser looks like it didn't affect your use case.

Licenser commented 2 years ago

Ja not much showed up in the benchmarks @mfelsche wanted to do some additional benchmarks perhaps we learn a bit more there.

mjp41 commented 1 year ago

This is all in the package.