search

SchrodingersGat / KiBoM

Configurable BoM generation tool for KiCad EDA (http://kicad.org/)
MIT License
352 stars 95 forks source link

Fix DNC (isFixed) #105

Closed set-soft closed 3 years ago

set-soft commented 3 years ago

Now that prefs.pcbConfig is a list we can't do: opt[1:].lower() == self.prefs.pcbConfig.lower() I also figured out that there is no need to check for pcbConfig Additionally this patch inverts the return value so the name of the function makes sense (was inverted).

SchrodingersGat commented 3 years ago

Thanks for the fixes :)

set-soft commented 3 years ago

You welcome. It would be nice if you drop some comments on the other PRs I sent. I explained all the PRs here:

https://github.com/INTI-CMNB/KiBoM/blob/master/doc/Fork_PRs.md