Fix Python 2 issues - Githubissues

SchrodingersGat / KiBoM

Configurable BoM generation tool for KiCad EDA (http://kicad.org/)

MIT License

352 stars 95 forks source link

Fix Python 2 issues #128

Closed set-soft closed 3 years ago

set-soft commented 3 years ago

This patch fixes two Python 2.7 compatibility issues:

The ConfigParser fallback, introduced in Python 3. Introduced by me on PR #121
The use of f-strings in PR #127, they need Python 3.6 or newer

Note that for the first I introduced a helpful member checkStr, it was designed to be used in various places, but this is part of a bigger patch delayed by PR #112 an #120. The patch also fixes #123. To get an idea the patch is INTI-CMNB/kibom#11

SchrodingersGat commented 3 years ago

Thanks!

set-soft commented 3 years ago

It looks like I wasn't clear, sorry. This patch (#128) contains a few lines from INTI-CMNB/KiBoM#11 The patch to fully fix #123 is INTI-CMNB/KiBoM#11 I'm not doing a PR for INTI-CMNB/KiBoM#11 because it strongly collides with PRs #112 and #120 The collision is because a lot of lines from #112 and #120 are also modified by INTI-CMNB/KiBoM#11