Fix to the variants logic.

SchrodingersGat / KiBoM

Configurable BoM generation tool for KiCad EDA (http://kicad.org/)

MIT License

352 stars 95 forks source link

Fix to the variants logic. #137

Closed set-soft closed 3 years ago

set-soft commented 3 years ago

The problem was reported by @RomaVis Personally I didn't like his two PRs, both had flaws and the changes in the code are larger than this patch. So now we have two options ;-) Fixes SchrodingersGat/KiBoM#136

SchrodingersGat commented 3 years ago

Hey @set-soft sorry that these have gone stale.

Can you please clarify - if this PR is merged, #136 is no longer required, correct?

set-soft commented 3 years ago

Hi @SchrodingersGat !

Correct. This fix is for the same, but is modified in a way that the code remains more similar to the original one. I did it to keep the code more familiar. It passes the tests mentioned by @RomaVis

SchrodingersGat commented 3 years ago

Ok, thanks for the clarification.