False should not be used in template bom.ini file, as True does not work

SchrodingersGat / KiBoM

Configurable BoM generation tool for KiCad EDA (http://kicad.org/)

MIT License

350 stars 95 forks source link

False should not be used in template bom.ini file, as True does not work #165

Closed retiredfeline closed 2 years ago

retiredfeline commented 2 years ago

In a few places in the template bom.ini file, parameters are set to False. This suggests that to negate it, one should use True. But this is not the case, only 1 works. Therefore I suggest all instances of False be changed to 0 to not mislead

complex_variant = False
hide_headers = False
hide_pcb_info = False
digikey_link = False

set-soft commented 2 years ago

This is repeated, take a look at #67 The patch I mention fixes the lack of "True", even when the generated files defaults to 0/1.

SchrodingersGat commented 2 years ago

Duplicate of https://github.com/SchrodingersGat/KiBoM/issues/67