SchrodingersGat / KiBoM

Configurable BoM generation tool for KiCad EDA (http://kicad.org/)
MIT License
353 stars 95 forks source link

Add flag to output variant name to BoM filename #58

Closed trentks closed 4 years ago

trentks commented 4 years ago

Hi @SchrodingersGat,

Just following up from yesterdays pull you did for #37 which added support for multiple variants. I had seen the value in adding these variants names to the BoM filename, and @AngusP (author of #37) had intended himself to add support for this. I believe this patch I have written satisfies this feature.

There is a certain amount of personal preference when it comes to how this variant name actually gets included in the filename so in particular I would advise that you review line 183 of KiBOM_CLI.py (and therefore line 210 of README.md).

Cheers.

Changes made:

Changes to KiBOM_CLI.py:

Changes to README.md:

Changes to bomlib/preferences.py:

SchrodingersGat commented 4 years ago

This all seems quite reasonable. Thanks for the contribution!