Schroedinger-Hat / ImageGoNord-cli

A python client used for ImageGoNord
GNU General Public License v3.0
10 stars 3 forks source link

--no-avg parameter specified but it creates the same image #11

Open BugliL opened 2 years ago

BugliL commented 2 years ago

I run the client with -na parameter with a rainbow image (this one https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_square.png) but it seems to have no differences. Do I need to specify more parameters?

To Reproduce Steps to reproduce the behavior: Clone my fork repository and run tests You can find a test here https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/unit/test_client_advanced_behavior.py

The full commands are

python /home/buglil/Desktop/ImageGoNord-cli/src/cli.py -i=/home/buglil/Desktop/ImageGoNord-cli/tests/data/rainbow_square.png -o=/tmp/tmpen591wm6/output.png -na
python /home/buglil/Desktop/ImageGoNord-cli/src/cli.py -i=/home/buglil/Desktop/ImageGoNord-cli/tests/data/rainbow_square.png -o=/tmp/tmpen591wm6/output.png 

Expected behavior Having a different image if -na applied or not Start image https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_square.png Image with -na option https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_nord_na_square.png Image without -na option https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_nord_square.png

Wabri commented 2 years ago

You are right, it seems something is broken on this option.

BugliL commented 2 years ago

I checked the code and this do not seems to be a client problem, can you confirm it?

Wabri commented 2 years ago

I guess so, we should open a issue on the imagegonord-pip

TheJoin95 commented 7 months ago

What was the issue on this one? @Wabri @BugliL ?

Wabri commented 7 months ago

Is it not clear in the description?