search

Schroedinger-Hat / ImageGoNord-cli

A python client used for ImageGoNord
GNU General Public License v3.0
10 stars 3 forks source link

Multiple image parameters doesn't work #18

Open Artmorse opened 6 months ago

Artmorse commented 6 months ago

Describe the bug Passing multiple image parameters will generate a single image.

To Reproduce

python3 src/cli.py --img='./input-folder/01.jpg' --img='./input-folder/02.jpg'

Expected behavior I would like to have an output per image input or a message informing the user that this feature is not supported.

Wabri commented 6 months ago

ATM it works like that because we simply think on process one image per execution, but maybe we can think about having something like this:

python3 src/cli.py --img='./input-folder/01.jpg,./input-folder/02.jpg'

to be more clear put every images into the --img argument using , or something more human readable, what do you think?

Artmorse commented 6 months ago

Yes, I don't have preferences on that point.

My underlying concern is to have better validation. We need the user to know what we're supporting or not.

We can wait for the @BugliL refactoring before digging into this issue though!