Closed 05Alston closed 1 year ago
Hi, thanks for adding the video support, overall it's looking super! I added couple of comments on the debug messages.
I see there are some part hardcoded with Nord palette: we would like to extend this also to other palettes, do you think it would be possible?
Could I ask you to add a demo video in your PR description, and also update the readme by specifying this usage (and add the demo video). Thanks!
I see there are some part hardcoded with Nord palette: we would like to extend this also to other palettes, do you think it would be possible?
I've replied to this in the above comment .
update the readme by specifying this usage (and add the demo video).
Updated the README file
For some reason ffmpeg is refusing to convert to gif files directly. I'm looking to fix this issue. Also, I've coded the code to only give mp4 as output.
Original
Converted
Original
Converted
For some reason ffmpeg is refusing to convert to gif files directly. I'm looking to fix this issue
Fixed this issue as well.
The code to run the above program would be
from ImageGoNord import NordPaletteFile, GoNord
go_nord = GoNord()
go_nord.convert_video(
input_file,
"nord", #color palette name
_frames_per_batch = 200 #optional parameter
)
We should also update the image-go-nord-cli repository with these changes. I think I'm going to take the image-go-nord web repository, @Wabri @05Alston would you like to take the CLI?
To try the conversion,
A higher number of frames per batch means more memory consumption but faster execution as there'll be less parts to merge.
On the first execution, a
nord.npz
color map file will be generated for faster execution.