search

Schroedinger-Hat / ImageGoNord-pip

A tool that can convert your rgb images to nordtheme palette
https://ign.schroedinger-hat.org
GNU Affero General Public License v3.0
172 stars 13 forks source link

Example video appears to be corrupt when viewed in Firefox #15

Closed realitychemist closed 7 months ago

realitychemist commented 8 months ago

The example video in the documentation (on this repo, not PyPI) appears as corrupted on Firefox 123.0, on both desktop (linux) and mobile (android 13) versions of the browser:

Video can't be played because the file is corrupt

This seems to be a compatibility issue with Firefox in particular, as the video appears and plays correctly when using Chrome 122.0 (on the same linux machine that gets the corrupted file error with Firefox). I don't have easy access to Safari right now to see how a WebKit-based browser handles it.

TheJoin95 commented 8 months ago

Thank you, I'll have a look on that in the week

TheJoin95 commented 8 months ago

Are you able to reproduce it also via our website? Checking if the issue is in our current implementation of ffmpeg

realitychemist commented 8 months ago

(Sorry, just saw this notification)

Yes, I can reproduce the issue using the converter on the website. Here's the test video I used:

https://github.com/Schrodinger-Hat/ImageGoNord-pip/assets/12576960/f35ed235-84b4-437a-bf9c-8a28c5b12feb

And here's the output video (all default settings):

https://github.com/Schrodinger-Hat/ImageGoNord-pip/assets/12576960/ce5c14e2-4537-4525-a65b-f0b285b91e27

Output video plays normally in VLC, but Firefox says the video is corrupted and won't play it.

TheJoin95 commented 7 months ago

update: I'm still on it, trying to figure this out. It's an issue with our ffmpeg commands used in the convert_video method