search

Schum123 / svelte-loading-spinners

A collection of loading spinner components for SvelteJs
https://schum123.github.io/svelte-loading-spinners/
MIT License
511 stars 35 forks source link

Is NPM Package working? #10

Closed telkamp closed 3 years ago

telkamp commented 3 years ago

Does anyone use the package "svelte-loading-spinners": 0.1.1 from https://www.npmjs.com/package/svelte-loading-spinners? It seems not to work. Even if it is published 3 month ago, some of the newer components are not included in the package (e.g. Moon, Square)

The example available in this repository includes the components directly from source code, not from the npm package. BTW, the bundle files are committed to the repository here. But when I build the example again, it tells me that the components Moon & Square are not defined...

Schum123 commented 3 years ago

Hi @telkamp,

They work fine for me.

See this repl, https://svelte.dev/repl/c283160b21ed4d8fbc36baf70cdc52a5?version=3.29.4

telkamp commented 3 years ago

Thank you, your example works for me too. My problem was that I used the package.json shipped with your example and I did not checked the dependencies. This package.json points to a very old version of svelte-loading-spinners: "svelte-loading-spinners": "^0.0.19" that does not work with the example code... So NPM is working, but the example seems to be inconsistent. Thank you again!

Schum123 commented 3 years ago

Cool! I will update the example to the correct version :)