search

SchumacherFM / Magento2-Mocks

This Magento2 module provides mock classes when you have physically removed unneeded core modules with dependencies.
https://cyrillschumacher.com/projects/2018-07-01-magento2-mocks/
19 stars 4 forks source link

InstallData before Magento_ConfigurableProduct #3

Open Swahjak opened 6 years ago

Swahjak commented 6 years ago

The installer (Magento 2.3.0-alpha62) fails due to the Magento_ConfigurableProduct module being installer before SchumacherFM_Mocks causing the following error:

Module 'Magento_ConfigurableProduct':

In PatchApplier.php line 167:

  Attribute with ID: "msrp" does not exist

I've added a sequence entry in vendor/magento/module-configurable-product/etc/module.xml which fixes the error , validating that the sequence of the installer is the problem. But I'm not aware of any method that allows a module to declare a before sequence. Any thoughts on this?

SchumacherFM commented 6 years ago

Thank you for reporting. Please do not change core code ;-)

You can try to replce this entry:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
    <module name="SchumacherFM_Mocks" setup_version="0.1.0">
        <sequence>
            <module name="Magento_Catalog"/>
            <module name="Magento_CatalogImportExport"/>
        </sequence>
    </module>
</config>

with this one:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
    <module name="SchumacherFM_Mocks" setup_version="0.1.0">
        <sequence>
            <module name="Magento_Store"/>
            <module name="Magento_Catalog"/>
            <module name="Magento_CatalogImportExport"/>
        </sequence>
    </module>
</config>

in the Magento2-Mocks/etc/module.xml - maybe you can even remove the Catalog sequences.

If it works we can merge it here...

Swahjak commented 6 years ago

Thank you for reporting. Please do not change core code ;-) Just for testing purposes, everything is nicely tucked away in composer packages.

Edit; I've tried the suggestion, both with and without the catalog sequences, on a clean install. No database, no caches, no nothing. There are no existing dependencies on MSRP in any of the other modules.

The problem remains and is in the same position as before. The ConfigurableProduct module.xml looks like this in 2.3.0-alpha62 (same as 2.2):

<?xml version="1.0"?>
<!--
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
    <module name="Magento_ConfigurableProduct" >
        <sequence>
            <module name="Magento_Catalog"/>
            <module name="Magento_Msrp"/>
            <module name="Magento_CatalogInventory"/>
            <module name="Magento_Sales"/>
            <module name="Magento_Quote"/>
            <module name="Magento_Checkout"/>
        </sequence>
    </module>
</config>
Starting Magento installation:
File permissions check...
[Progress: 1 / 525]
Required extensions check...
[Progress: 2 / 525]
Enabling Maintenance Mode...
[Progress: 3 / 525]
Installing deployment configuration...
[Progress: 4 / 525]
Installing database schema:
Schema creation/updates:
Module 'Magento_Store':
[Progress: 5 / 525]
Module 'Magento_AdminNotification':
[Progress: 6 / 525]
Module 'Magento_AdvancedPricingImportExport':
[Progress: 7 / 525]
Module 'Magento_Directory':
[Progress: 8 / 525]
Module 'Magento_Amqp':
[Progress: 9 / 525]
Module 'Magento_Backend':
[Progress: 10 / 525]
Module 'Magento_Authorization':
[Progress: 11 / 525]
Module 'Magento_Search':
[Progress: 12 / 525]
Module 'Magento_Backup':
[Progress: 13 / 525]
Module 'Magento_Theme':
[Progress: 14 / 525]
Module 'Magento_Eav':
[Progress: 15 / 525]
Module 'Magento_CacheInvalidate':
[Progress: 16 / 525]
Module 'Magento_Customer':
[Progress: 17 / 525]
Module 'Magento_Indexer':
[Progress: 18 / 525]
Module 'Magento_GraphQl':
[Progress: 19 / 525]
Module 'Magento_CatalogImportExport':
[Progress: 20 / 525]
Module 'Magento_Variable':
[Progress: 21 / 525]
Module 'Magento_Rule':
[Progress: 22 / 525]
Module 'Magento_Cms':
[Progress: 23 / 525]
Module 'Magento_Catalog':
[Progress: 24 / 525]
Module 'Magento_CatalogUrlRewriteGraphQl':
[Progress: 25 / 525]
Module 'Magento_Widget':
[Progress: 26 / 525]
Module 'Magento_Payment':
[Progress: 27 / 525]
Module 'Magento_Quote':
[Progress: 28 / 525]
Module 'Magento_EavGraphQl':
[Progress: 29 / 525]
Module 'Magento_CmsUrlRewrite':
[Progress: 30 / 525]
Module 'Magento_CmsUrlRewriteGraphQl':
[Progress: 31 / 525]
Module 'Magento_Config':
[Progress: 32 / 525]
Module 'Magento_ConfigurableImportExport':
[Progress: 33 / 525]
Module 'Magento_SalesSequence':
[Progress: 34 / 525]
Module 'Magento_StoreGraphQl':
[Progress: 35 / 525]
Module 'Magento_Sales':
[Progress: 36 / 525]
Module 'Magento_Contact':
[Progress: 37 / 525]
Module 'Magento_Cookie':
[Progress: 38 / 525]
Module 'Magento_Cron':
[Progress: 39 / 525]
Module 'Magento_CurrencySymbol':
[Progress: 40 / 525]
Module 'Ho_nl_NL':
[Progress: 41 / 525]
Module 'Magento_CustomerGraphQl':
[Progress: 42 / 525]
Module 'Magento_CustomerImportExport':
[Progress: 43 / 525]
Module 'Magento_Deploy':
[Progress: 44 / 525]
Module 'Magento_Developer':
[Progress: 45 / 525]
Module 'Magento_CatalogInventory':
[Progress: 46 / 525]
Module 'Magento_CatalogGraphQl':
[Progress: 47 / 525]
Module 'Magento_Bundle':
[Progress: 48 / 525]
Module 'Magento_BundleGraphQl':
[Progress: 49 / 525]
Module 'Magento_CatalogRule':
[Progress: 50 / 525]
Module 'Magento_Email':
[Progress: 51 / 525]
Module 'Magento_User':
[Progress: 52 / 525]
Module 'Magento_GiftMessage':
[Progress: 53 / 525]
Module 'Magento_GoogleAnalytics':
[Progress: 54 / 525]
Module 'Magento_Checkout':
[Progress: 55 / 525]
Module 'Magento_GroupedImportExport':
[Progress: 56 / 525]
Module 'Magento_GroupedProduct':
[Progress: 57 / 525]
Module 'Magento_GroupedProductGraphQl':
[Progress: 58 / 525]
Module 'Magento_ImportExport':
[Progress: 59 / 525]
Module 'Magento_CatalogSearch':
[Progress: 60 / 525]
Module 'Magento_InstantPurchase':
[Progress: 61 / 525]
Module 'Magento_Security':
[Progress: 62 / 525]
Module 'Magento_LayeredNavigation':
[Progress: 63 / 525]
Module 'Magento_MediaStorage':
[Progress: 64 / 525]
Module 'Magento_MessageQueue':
[Progress: 65 / 525]
Module 'Magento_MysqlMq':
[Progress: 66 / 525]
Module 'Magento_Newsletter':
[Progress: 67 / 525]
Module 'Magento_OfflinePayments':
[Progress: 68 / 525]
Module 'Magento_SalesRule':
[Progress: 69 / 525]
Module 'Magento_PageCache':
[Progress: 70 / 525]
Module 'Magento_CheckoutAgreements':
[Progress: 71 / 525]
Module 'Magento_Vault':
[Progress: 72 / 525]
Module 'Magento_Persistent':
[Progress: 73 / 525]
Module 'Magento_ProductAlert':
[Progress: 74 / 525]
Module 'Magento_ProductVideo':
[Progress: 75 / 525]
Module 'Magento_ConfigurableProduct':
[Progress: 76 / 525]
Module 'Magento_Reports':
[Progress: 77 / 525]
Module 'Magento_RequireJs':
[Progress: 78 / 525]
Module 'Magento_Review':
[Progress: 79 / 525]
Module 'Magento_Robots':
[Progress: 80 / 525]
Module 'Magento_AdvancedSearch':
[Progress: 81 / 525]
Module 'Magento_ConfigurableProductGraphQl':
[Progress: 82 / 525]
Module 'Magento_SalesInventory':
[Progress: 83 / 525]
Module 'Magento_OfflineShipping':
[Progress: 84 / 525]
Module 'Magento_Captcha':
[Progress: 85 / 525]
Module 'Magento_Elasticsearch':
[Progress: 86 / 525]
Module 'Magento_Integration':
[Progress: 87 / 525]
Module 'Magento_Ui':
[Progress: 88 / 525]
Module 'Magento_Sitemap':
[Progress: 89 / 525]
Module 'Magento_AsynchronousOperations':
[Progress: 90 / 525]
Module 'Magento_DownloadableGraphQl':
[Progress: 91 / 525]
Module 'Magento_Webapi':
[Progress: 92 / 525]
Module 'Magento_SwaggerWebapi':
[Progress: 93 / 525]
Module 'Magento_SwaggerWebapiAsync':
[Progress: 94 / 525]
Module 'Magento_SwatchesGraphQl':
[Progress: 95 / 525]
Module 'Magento_Tax':
[Progress: 96 / 525]
Module 'Magento_TaxGraphQl':
[Progress: 97 / 525]
Module 'Magento_ConfigurableProductSales':
[Progress: 98 / 525]
Module 'Magento_Tinymce3':
[Progress: 99 / 525]
Module 'Magento_Translation':
[Progress: 100 / 525]
Module 'Magento_Shipping':
[Progress: 101 / 525]
Module 'Magento_UrlRewrite':
[Progress: 102 / 525]
Module 'Magento_UrlRewriteGraphQl':
[Progress: 103 / 525]
Module 'Magento_EncryptionKey':
[Progress: 104 / 525]
Module 'Magento_CatalogUrlRewrite':
[Progress: 105 / 525]
Module 'Magento_Paypal':
[Progress: 106 / 525]
Module 'Magento_Version':
[Progress: 107 / 525]
Module 'Magento_Swagger':
[Progress: 108 / 525]
Module 'Magento_WebapiAsync':
[Progress: 109 / 525]
Module 'Magento_WebapiSecurity':
[Progress: 110 / 525]
Module 'Magento_WeeeGraphQl':
[Progress: 111 / 525]
Module 'Magento_CatalogWidget':
[Progress: 112 / 525]
Module 'Magento_Wishlist':
[Progress: 113 / 525]
Module 'SchumacherFM_Mocks':
[Progress: 114 / 525]
Module 'Vendor_Core':
[Progress: 115 / 525]
Module 'Vendor_Brand':
Installing schema... 
[Progress: 116 / 525]
Module 'Vendor_Cloud':
[Progress: 117 / 525]
Module 'Vendor_AttributeSpecification':
Installing schema... 
[Progress: 118 / 525]
Module 'Vendor_Email':
Installing schema... 
[Progress: 119 / 525]
Module 'Vendor_ReCaptcha':
[Progress: 120 / 525]
Module 'Vendor_Logger':
[Progress: 121 / 525]
Module 'Vendor_OrderGrid':
Installing schema... 
[Progress: 122 / 525]
Module 'Vendor_Patch':
[Progress: 123 / 525]
Module 'Vendor_PriceMatch':
Installing schema... 
[Progress: 124 / 525]
Module 'Vendor_ProductUsp':
[Progress: 125 / 525]
Module 'Vendor_ReviewAdvanced':
Installing schema... 
[Progress: 126 / 525]
Module 'Vendor_RequestQuotation':
Installing schema... 
[Progress: 127 / 525]
Module 'Vendor_Gdpr':
Installing schema... 
[Progress: 128 / 525]
Module 'Vendor_Rma':
Installing schema... 
[Progress: 129 / 525]
Module 'Vendor_Router':
Installing schema... 
[Progress: 130 / 525]
Module 'Vendor_Seo':
[Progress: 131 / 525]
Module 'Webfixit_OpCache':
[Progress: 132 / 525]
Schema post-updates:
Module 'Magento_Store':
[Progress: 133 / 525]
Module 'Magento_AdminNotification':
[Progress: 134 / 525]
Module 'Magento_AdvancedPricingImportExport':
[Progress: 135 / 525]
Module 'Magento_Directory':
[Progress: 136 / 525]
Module 'Magento_Amqp':
Running schema recurring...
[Progress: 137 / 525]
Module 'Magento_Backend':
[Progress: 138 / 525]
Module 'Magento_Authorization':
[Progress: 139 / 525]
Module 'Magento_Search':
[Progress: 140 / 525]
Module 'Magento_Backup':
[Progress: 141 / 525]
Module 'Magento_Theme':
[Progress: 142 / 525]
Module 'Magento_Eav':
[Progress: 143 / 525]
Module 'Magento_CacheInvalidate':
[Progress: 144 / 525]
Module 'Magento_Customer':
[Progress: 145 / 525]
Module 'Magento_Indexer':
Running schema recurring...
[Progress: 146 / 525]
Module 'Magento_GraphQl':
[Progress: 147 / 525]
Module 'Magento_CatalogImportExport':
[Progress: 148 / 525]
Module 'Magento_Variable':
[Progress: 149 / 525]
Module 'Magento_Rule':
[Progress: 150 / 525]
Module 'Magento_Cms':
[Progress: 151 / 525]
Module 'Magento_Catalog':
Running schema recurring...
[Progress: 152 / 525]
Module 'Magento_CatalogUrlRewriteGraphQl':
[Progress: 153 / 525]
Module 'Magento_Widget':
[Progress: 154 / 525]
Module 'Magento_Payment':
[Progress: 155 / 525]
Module 'Magento_Quote':
[Progress: 156 / 525]
Module 'Magento_EavGraphQl':
[Progress: 157 / 525]
Module 'Magento_CmsUrlRewrite':
[Progress: 158 / 525]
Module 'Magento_CmsUrlRewriteGraphQl':
[Progress: 159 / 525]
Module 'Magento_Config':
[Progress: 160 / 525]
Module 'Magento_ConfigurableImportExport':
[Progress: 161 / 525]
Module 'Magento_SalesSequence':
Running schema recurring...
[Progress: 162 / 525]
Module 'Magento_StoreGraphQl':
[Progress: 163 / 525]
Module 'Magento_Sales':
[Progress: 164 / 525]
Module 'Magento_Contact':
[Progress: 165 / 525]
Module 'Magento_Cookie':
[Progress: 166 / 525]
Module 'Magento_Cron':
Running schema recurring...
[Progress: 167 / 525]
Module 'Magento_CurrencySymbol':
[Progress: 168 / 525]
Module 'Ho_nl_NL':
[Progress: 169 / 525]
Module 'Magento_CustomerGraphQl':
[Progress: 170 / 525]
Module 'Magento_CustomerImportExport':
[Progress: 171 / 525]
Module 'Magento_Deploy':
[Progress: 172 / 525]
Module 'Magento_Developer':
[Progress: 173 / 525]
Module 'Magento_CatalogInventory':
Running schema recurring...
[Progress: 174 / 525]
Module 'Magento_CatalogGraphQl':
[Progress: 175 / 525]
Module 'Magento_Bundle':
Running schema recurring...
[Progress: 176 / 525]
Module 'Magento_BundleGraphQl':
[Progress: 177 / 525]
Module 'Magento_CatalogRule':
[Progress: 178 / 525]
Module 'Magento_Email':
[Progress: 179 / 525]
Module 'Magento_User':
[Progress: 180 / 525]
Module 'Magento_GiftMessage':
[Progress: 181 / 525]
Module 'Magento_GoogleAnalytics':
[Progress: 182 / 525]
Module 'Magento_Checkout':
[Progress: 183 / 525]
Module 'Magento_GroupedImportExport':
[Progress: 184 / 525]
Module 'Magento_GroupedProduct':
[Progress: 185 / 525]
Module 'Magento_GroupedProductGraphQl':
[Progress: 186 / 525]
Module 'Magento_ImportExport':
[Progress: 187 / 525]
Module 'Magento_CatalogSearch':
[Progress: 188 / 525]
Module 'Magento_InstantPurchase':
[Progress: 189 / 525]
Module 'Magento_Security':
[Progress: 190 / 525]
Module 'Magento_LayeredNavigation':
[Progress: 191 / 525]
Module 'Magento_MediaStorage':
[Progress: 192 / 525]
Module 'Magento_MessageQueue':
[Progress: 193 / 525]
Module 'Magento_MysqlMq':
Running schema recurring...
[Progress: 194 / 525]
Module 'Magento_Newsletter':
[Progress: 195 / 525]
Module 'Magento_OfflinePayments':
[Progress: 196 / 525]
Module 'Magento_SalesRule':
[Progress: 197 / 525]
Module 'Magento_PageCache':
[Progress: 198 / 525]
Module 'Magento_CheckoutAgreements':
[Progress: 199 / 525]
Module 'Magento_Vault':
[Progress: 200 / 525]
Module 'Magento_Persistent':
[Progress: 201 / 525]
Module 'Magento_ProductAlert':
Running schema recurring...
[Progress: 202 / 525]
Module 'Magento_ProductVideo':
[Progress: 203 / 525]
Module 'Magento_ConfigurableProduct':
Running schema recurring...
[Progress: 204 / 525]
Module 'Magento_Reports':
Running schema recurring...
[Progress: 205 / 525]
Module 'Magento_RequireJs':
[Progress: 206 / 525]
Module 'Magento_Review':
[Progress: 207 / 525]
Module 'Magento_Robots':
[Progress: 208 / 525]
Module 'Magento_AdvancedSearch':
[Progress: 209 / 525]
Module 'Magento_ConfigurableProductGraphQl':
[Progress: 210 / 525]
Module 'Magento_SalesInventory':
[Progress: 211 / 525]
Module 'Magento_OfflineShipping':
[Progress: 212 / 525]
Module 'Magento_Captcha':
[Progress: 213 / 525]
Module 'Magento_Elasticsearch':
[Progress: 214 / 525]
Module 'Magento_Integration':
Running schema recurring...
[Progress: 215 / 525]
Module 'Magento_Ui':
[Progress: 216 / 525]
Module 'Magento_Sitemap':
[Progress: 217 / 525]
Module 'Magento_AsynchronousOperations':
[Progress: 218 / 525]
Module 'Magento_DownloadableGraphQl':
[Progress: 219 / 525]
Module 'Magento_Webapi':
[Progress: 220 / 525]
Module 'Magento_SwaggerWebapi':
[Progress: 221 / 525]
Module 'Magento_SwaggerWebapiAsync':
[Progress: 222 / 525]
Module 'Magento_SwatchesGraphQl':
[Progress: 223 / 525]
Module 'Magento_Tax':
[Progress: 224 / 525]
Module 'Magento_TaxGraphQl':
[Progress: 225 / 525]
Module 'Magento_ConfigurableProductSales':
[Progress: 226 / 525]
Module 'Magento_Tinymce3':
[Progress: 227 / 525]
Module 'Magento_Translation':
[Progress: 228 / 525]
Module 'Magento_Shipping':
[Progress: 229 / 525]
Module 'Magento_UrlRewrite':
[Progress: 230 / 525]
Module 'Magento_UrlRewriteGraphQl':
[Progress: 231 / 525]
Module 'Magento_EncryptionKey':
[Progress: 232 / 525]
Module 'Magento_CatalogUrlRewrite':
Running schema recurring...
[Progress: 233 / 525]
Module 'Magento_Paypal':
[Progress: 234 / 525]
Module 'Magento_Version':
[Progress: 235 / 525]
Module 'Magento_Swagger':
[Progress: 236 / 525]
Module 'Magento_WebapiAsync':
[Progress: 237 / 525]
Module 'Magento_WebapiSecurity':
[Progress: 238 / 525]
Module 'Magento_WeeeGraphQl':
[Progress: 239 / 525]
Module 'Magento_CatalogWidget':
[Progress: 240 / 525]
Module 'Magento_Wishlist':
Running schema recurring...
[Progress: 241 / 525]
Module 'SchumacherFM_Mocks':
[Progress: 242 / 525]
Module 'Vendor_Core':
[Progress: 243 / 525]
Module 'Vendor_Brand':
[Progress: 244 / 525]
Module 'Vendor_Cloud':
[Progress: 245 / 525]
Module 'Vendor_AttributeSpecification':
[Progress: 246 / 525]
Module 'Vendor_Email':
[Progress: 247 / 525]
Module 'Vendor_ReCaptcha':
[Progress: 248 / 525]
Module 'Vendor_Logger':
[Progress: 249 / 525]
Module 'Vendor_OrderGrid':
[Progress: 250 / 525]
Module 'Vendor_Patch':
[Progress: 251 / 525]
Module 'Vendor_PriceMatch':
[Progress: 252 / 525]
Module 'Vendor_ProductUsp':
[Progress: 253 / 525]
Module 'Vendor_ReviewAdvanced':
[Progress: 254 / 525]
Module 'Vendor_RequestQuotation':
[Progress: 255 / 525]
Module 'Vendor_Gdpr':
[Progress: 256 / 525]
Module 'Vendor_Rma':
[Progress: 257 / 525]
Module 'Vendor_Router':
[Progress: 258 / 525]
Module 'Vendor_Seo':
[Progress: 259 / 525]
Module 'Webfixit_OpCache':
[Progress: 260 / 525]
[Progress: 261 / 525]
Installing user configuration...
[Progress: 262 / 525]
Enabling caches:
Current status:
Array
(
    [config] => 1
    [layout] => 1
    [block_html] => 1
    [collections] => 1
    [reflection] => 1
    [db_ddl] => 1
    [compiled_config] => 1
    [eav] => 1
    [customer_notification] => 1
    [full_page] => 1
    [config_integration] => 1
    [config_integration_api] => 1
    [config_webservice] => 1
    [translate] => 1
)

[Progress: 263 / 525]
Installing data...
Data install/update:
Module 'Magento_Store':
[Progress: 264 / 525]
Module 'Magento_AdminNotification':
[Progress: 265 / 525]
Module 'Magento_AdvancedPricingImportExport':
[Progress: 266 / 525]
Module 'Magento_Directory':
[Progress: 267 / 525]
Module 'Magento_Amqp':
[Progress: 268 / 525]
Module 'Magento_Backend':
[Progress: 269 / 525]
Module 'Magento_Authorization':
[Progress: 270 / 525]
Module 'Magento_Search':
[Progress: 271 / 525]
Module 'Magento_Backup':
[Progress: 272 / 525]
Module 'Magento_Theme':
[Progress: 273 / 525]
Module 'Magento_Eav':
[Progress: 274 / 525]
Module 'Magento_CacheInvalidate':
[Progress: 275 / 525]
Module 'Magento_Customer':
[Progress: 276 / 525]
Module 'Magento_Indexer':
[Progress: 277 / 525]
Module 'Magento_GraphQl':
[Progress: 278 / 525]
Module 'Magento_CatalogImportExport':
[Progress: 279 / 525]
Module 'Magento_Variable':
[Progress: 280 / 525]
Module 'Magento_Rule':
[Progress: 281 / 525]
Module 'Magento_Cms':
[Progress: 282 / 525]
Module 'Magento_Catalog':
[Progress: 283 / 525]
Module 'Magento_CatalogUrlRewriteGraphQl':
[Progress: 284 / 525]
Module 'Magento_Widget':
[Progress: 285 / 525]
Module 'Magento_Payment':
[Progress: 286 / 525]
Module 'Magento_Quote':
[Progress: 287 / 525]
Module 'Magento_EavGraphQl':
[Progress: 288 / 525]
Module 'Magento_CmsUrlRewrite':
[Progress: 289 / 525]
Module 'Magento_CmsUrlRewriteGraphQl':
[Progress: 290 / 525]
Module 'Magento_Config':
[Progress: 291 / 525]
Module 'Magento_ConfigurableImportExport':
[Progress: 292 / 525]
Module 'Magento_SalesSequence':
[Progress: 293 / 525]
Module 'Magento_StoreGraphQl':
[Progress: 294 / 525]
Module 'Magento_Sales':
[Progress: 295 / 525]
Module 'Magento_Contact':
[Progress: 296 / 525]
Module 'Magento_Cookie':
[Progress: 297 / 525]
Module 'Magento_Cron':
[Progress: 298 / 525]
Module 'Magento_CurrencySymbol':
[Progress: 299 / 525]
Module 'Ho_nl_NL':
[Progress: 300 / 525]
Module 'Magento_CustomerGraphQl':
[Progress: 301 / 525]
Module 'Magento_CustomerImportExport':
[Progress: 302 / 525]
Module 'Magento_Deploy':
[Progress: 303 / 525]
Module 'Magento_Developer':
[Progress: 304 / 525]
Module 'Magento_CatalogInventory':
[Progress: 305 / 525]
Module 'Magento_CatalogGraphQl':
[Progress: 306 / 525]
Module 'Magento_Bundle':
[Progress: 307 / 525]
Module 'Magento_BundleGraphQl':
[Progress: 308 / 525]
Module 'Magento_CatalogRule':
[Progress: 309 / 525]
Module 'Magento_Email':
[Progress: 310 / 525]
Module 'Magento_User':
[Progress: 311 / 525]
Module 'Magento_GiftMessage':
[Progress: 312 / 525]
Module 'Magento_GoogleAnalytics':
[Progress: 313 / 525]
Module 'Magento_Checkout':
[Progress: 314 / 525]
Module 'Magento_GroupedImportExport':
[Progress: 315 / 525]
Module 'Magento_GroupedProduct':
[Progress: 316 / 525]
Module 'Magento_GroupedProductGraphQl':
[Progress: 317 / 525]
Module 'Magento_ImportExport':
[Progress: 318 / 525]
Module 'Magento_CatalogSearch':
[Progress: 319 / 525]
Module 'Magento_InstantPurchase':
[Progress: 320 / 525]
Module 'Magento_Security':
[Progress: 321 / 525]
Module 'Magento_LayeredNavigation':
[Progress: 322 / 525]
Module 'Magento_MediaStorage':
[Progress: 323 / 525]
Module 'Magento_MessageQueue':
[Progress: 324 / 525]
Module 'Magento_MysqlMq':
[Progress: 325 / 525]
Module 'Magento_Newsletter':
[Progress: 326 / 525]
Module 'Magento_OfflinePayments':
[Progress: 327 / 525]
Module 'Magento_SalesRule':
[Progress: 328 / 525]
Module 'Magento_PageCache':
[Progress: 329 / 525]
Module 'Magento_CheckoutAgreements':
[Progress: 330 / 525]
Module 'Magento_Vault':
[Progress: 331 / 525]
Module 'Magento_Persistent':
[Progress: 332 / 525]
Module 'Magento_ProductAlert':
[Progress: 333 / 525]
Module 'Magento_ProductVideo':
[Progress: 334 / 525]
Module 'Magento_ConfigurableProduct':

In PatchApplier.php line 167:

  Attribute with ID: "msrp" does not exist  

setup:install [--amqp-host AMQP-HOST] [--amqp-port AMQP-PORT] [--amqp-user AMQP-USER] [--amqp-password AMQP-PASSWORD] [--amqp-virtualhost AMQP-VIRTUALHOST] [--amqp-ssl AMQP-SSL] [--amqp-ssl-options AMQP-SSL-OPTIONS] [--backend-frontname BACKEND-FRONTNAME] [--key KEY] [--db-host DB-HOST] [--db-name DB-NAME] [--db-user DB-USER] [--db-engine DB-ENGINE] [--db-password DB-PASSWORD] [--db-prefix DB-PREFIX] [--db-model DB-MODEL] [--db-init-statements DB-INIT-STATEMENTS] [-s|--skip-db-validation] [--http-cache-hosts HTTP-CACHE-HOSTS] [--session-save SESSION-SAVE] [--session-save-redis-host SESSION-SAVE-REDIS-HOST] [--session-save-redis-port SESSION-SAVE-REDIS-PORT] [--session-save-redis-password SESSION-SAVE-REDIS-PASSWORD] [--session-save-redis-timeout SESSION-SAVE-REDIS-TIMEOUT] [--session-save-redis-persistent-id SESSION-SAVE-REDIS-PERSISTENT-ID] [--session-save-redis-db SESSION-SAVE-REDIS-DB] [--session-save-redis-compression-threshold SESSION-SAVE-REDIS-COMPRESSION-THRESHOLD] [--session-save-redis-compression-lib SESSION-SAVE-REDIS-COMPRESSION-LIB] [--session-save-redis-log-level SESSION-SAVE-REDIS-LOG-LEVEL] [--session-save-redis-max-concurrency SESSION-SAVE-REDIS-MAX-CONCURRENCY] [--session-save-redis-break-after-frontend SESSION-SAVE-REDIS-BREAK-AFTER-FRONTEND] [--session-save-redis-break-after-adminhtml SESSION-SAVE-REDIS-BREAK-AFTER-ADMINHTML] [--session-save-redis-first-lifetime SESSION-SAVE-REDIS-FIRST-LIFETIME] [--session-save-redis-bot-first-lifetime SESSION-SAVE-REDIS-BOT-FIRST-LIFETIME] [--session-save-redis-bot-lifetime SESSION-SAVE-REDIS-BOT-LIFETIME] [--session-save-redis-disable-locking SESSION-SAVE-REDIS-DISABLE-LOCKING] [--session-save-redis-min-lifetime SESSION-SAVE-REDIS-MIN-LIFETIME] [--session-save-redis-max-lifetime SESSION-SAVE-REDIS-MAX-LIFETIME] [--session-save-redis-sentinel-master SESSION-SAVE-REDIS-SENTINEL-MASTER] [--session-save-redis-sentinel-servers SESSION-SAVE-REDIS-SENTINEL-SERVERS] [--session-save-redis-sentinel-verify-master SESSION-SAVE-REDIS-SENTINEL-VERIFY-MASTER] [--session-save-redis-sentinel-connect-retires SESSION-SAVE-REDIS-SENTINEL-CONNECT-RETIRES] [--cache-backend CACHE-BACKEND] [--cache-backend-redis-server CACHE-BACKEND-REDIS-SERVER] [--cache-backend-redis-db CACHE-BACKEND-REDIS-DB] [--cache-backend-redis-port CACHE-BACKEND-REDIS-PORT] [--cache-backend-redis-password CACHE-BACKEND-REDIS-PASSWORD] [--page-cache PAGE-CACHE] [--page-cache-redis-server PAGE-CACHE-REDIS-SERVER] [--page-cache-redis-db PAGE-CACHE-REDIS-DB] [--page-cache-redis-port PAGE-CACHE-REDIS-PORT] [--page-cache-redis-compress-data PAGE-CACHE-REDIS-COMPRESS-DATA] [--page-cache-redis-password PAGE-CACHE-REDIS-PASSWORD] [--base-url BASE-URL] [--language LANGUAGE] [--timezone TIMEZONE] [--currency CURRENCY] [--use-rewrites USE-REWRITES] [--use-secure USE-SECURE] [--base-url-secure BASE-URL-SECURE] [--use-secure-admin USE-SECURE-ADMIN] [--admin-use-security-key ADMIN-USE-SECURITY-KEY] [--admin-user ADMIN-USER] [--admin-password ADMIN-PASSWORD] [--admin-email ADMIN-EMAIL] [--admin-firstname ADMIN-FIRSTNAME] [--admin-lastname ADMIN-LASTNAME] [--cleanup-database] [--sales-order-increment-prefix SALES-ORDER-INCREMENT-PREFIX] [--use-sample-data] [--dump_enable DUMP_ENABLE] [--enable_modules [ENABLE_MODULES]] [--disable_modules [DISABLE_MODULES]] [--convert_old_scripts [CONVERT_OLD_SCRIPTS]] [-i|--interactive] [--safe-mode [SAFE-MODE]] [--data-restore [DATA-RESTORE]] [--dry-run [DRY-RUN]] [--magento-init-params MAGENTO-INIT-PARAMS]
Swahjak commented 6 years ago

Looking further into this; I do have a module (https://github.com/ho-nl/magento2-nl_NL) that always seems to come before some of the other Magento modules. But it's unclear to me why. I've tried clearing the config.php and Ho_nl_NL always comes after Magento_CurrencySymbol, but all the other modules seem to come after the core modules. (Not sure if the order in config.php is related to the install order but it does seem to be exactly the same order as listed in my previous comment.

Swahjak commented 6 years ago

Ok, besides the fact that I'm working on a Magento alpha branch, I would say this is a Magento 'bug'. The 2.3 branch seems to take a different approach to Setup using Magento\Framework\Setup\ModuleDataSetupInterface, Magento\Framework\Setup\Patch\DataPatchInterface, Magento\Framework\Setup\Patch\PatchVersionInterface and Magento\Framework\Setup\Patch\DependentPatchInterface (and probably some other interfaces). The DependentPatchInterface allows to create dependencies between patches and the Magento\ConfigurableProduct\Setup\Patch\Data\InstallInitialConfigurableAttributes should declare a dependency on Magento\Msrp\Setup\Patch\Data\InitializeMsrpAttributes, but it doesn't. Otherwise this would be fixable (but not backwards compatible to 2.2 I'm afraid).

I think I'll have to file a bug report and create a custom module for the time being which does not exclude Msrp or creates some nasty overrides. Unless you have any other ideas?