Closed hydrogen2oxygen closed 6 years ago
Thank you for the pull request and sorry I for my late reply.
Can you please:
@SchumacherFM Is it worth holding this PR until the fixes are in? Personally, this was a big blocker for me on using the jekyll exporter. I'm creating a fork right now so I can merge this and use it. Otherwise my videos are just gone.
Please fix at least the merge conflict and then I can merge it.
I will not.
@SchumacherFM I’ll see if I can whip up a new PR with the merge conflicts resolved. 👍
@chmac Thanks! That would be awesome!
@SchumacherFM I got a bit confused, but I think I've figured it out now. I think two of the commits from this PR have been cherry picked into master already. Now I don't see a merge conflict. Not sure when / how it was fixed, but on GitHub I get "This branch has no conflicts with the base branch" and when I tried a local merge, it worked without conflict.
Wanna merge it now?
@chmac Thanks for investigating. Indeed locally I could merge it without any complains.
Links inside a iframe (src) are transformed to "video templates".
Example: {{< youtube k2NuZhRlWCc >}}
When Hugo discovers this template syntax it will be transformed again in a iframe inside the HTML.