SchwaIndustries / ScrimBot

Discord bot for organizing Valorant custom games.
https://scrimbot.schwa.tech
MIT License
39 stars 20 forks source link

Overscoring is possible #10

Closed MomoMiles closed 4 years ago

MomoMiles commented 4 years ago

Describe the bug You can score a match that is already completed

To Reproduce 1: Create a match 2: Score a match 3: Score a match again

Expected behavior The bot will notice you scored already and prevent.

Bot Version 1.2.1

Additional context Could be fixed by allowing match edit AFTER match has been scored. More admin control clearly needed.

Kalissaac commented 4 years ago

Does this overwrite the score in the database with the new one or are two scores created inside?

Kalissaac commented 4 years ago

Yes it does, the PR should fix this.