search

SchwartzLizer / NimbleSurvey

MIT License
0 stars 0 forks source link

Start of the code review process 👋 #1

Open suho opened 11 months ago

suho commented 11 months ago

Hello Tanatip Denduangchai 👋, thank you for your effort on the code submission. I am Su, Engineering Lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

suho commented 11 months ago

@SchwartzLizer I have completed the first round of reviews. Please provide your feedback on all open issues

SchwartzLizer commented 11 months ago

@suho I appreciate you reviewing the code. I'll do my best because this is my first time reviewing code.

SchwartzLizer commented 11 months ago

@suho I have a question about the username and the password. I'm not sure when it was changed, but I can't login with "d**@***q.co" and the password "12345678." I need to use it for the code review phase.

Thank you for your support.

suho commented 11 months ago

@SchwartzLizer Sorry for the late reply, you could use our Register API to register a new account, and use it for your challenge

https://survey-api.nimblehq.co/api/docs/openapi#/paths/registrations/post

SchwartzLizer commented 11 months ago

@suho I get it. Thank you