revoked messages

[m00nty]

Revoked messages get deleted I don't think the patch is working.

[jeverling]

Same for me, with WhatsApp version 2.23.17.15, which was the latest version the patcher downloaded.

I tried a few different versions, but either the revoke patch didn't work (2.23.16.19, 2.23.17.15), or the signature fix didn't work (#23), (2.23.14.80, 2.23.15.82, 2.23.16.77).

Is there a known, recent non-beta version where revoke patch and signature fix work? Beta versions expire AFAIK, so it would be nice to be able to install a stable version that works. I tried to patch the same version that you attached to release 1.0.9, but I got a message that this version was expired (because it's a beta I assume).

Edit: It's probably not relevant for this issue, but just for the sake of completeness - I removed SendReceiptPatch.py before patching because I'm ok with sending read receipts and I didn't want to risk any eventuality that WhatsApp can detect this modification. But this shouldn't change anything related to message revocation patch I think.

[jeverling]

BTW, the latest stable apk can also be downloaded from https://www.whatsapp.com/android/

[Schwartzblat]

I am an IPhone user so it's kind of hard for me to test some of the changes :) Please let me know if the problem was fixed in this update @m00nty @jeverling .

[jeverling]

Thanks a lot Alon! Will try a bit later today and get back.

On Fri, 25 Aug 2023, 12:21 Alon Schwartzblat @.***> wrote:

I am an IPhone user so it's kind of hard for me to test some of the changes :) Please let me know if the problem was fixed in this update @m00nty https://github.com/m00nty @jeverling https://github.com/jeverling .

— Reply to this email directly, view it on GitHub https://github.com/Schwartzblat/WhatsAppPatcher/issues/29#issuecomment-1693534296, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5YWTG7OKK33XIWF2NDHTXXC7JDANCNFSM6AAAAAA23577UM . You are receiving this because you were mentioned.Message ID: @.***>

[jeverling]

Hi Alon, unfortunately the latest patched version you attached to release 1.0.9 crashes for me. It installs without issues, but when trying to open the app it shows the splash screen (from Meta) and then reproducibly crashes. Here is some logcat output, in case that helps:

08-25 16:11:17.357 17517 17517 E AndroidRuntime: FATAL EXCEPTION: main
08-25 16:11:17.357 17517 17517 E AndroidRuntime: Process: com.whatsapp, PID: 17517
08-25 16:11:17.357 17517 17517 E AndroidRuntime: java.lang.VerifyError: Verifier rejected class X.2pB: boolean X.2pB.A04(X.33c, boolean) failed to verify: boolean X.2pB.A04(X.33c, boolean): [0x2] return-void not expected (declaration of 'X.2pB' appears in /data/app/com.whatsapp-yWKLN7ROM94bK0XwNFSRGA==/base.apk:classes2.dex)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.A2M(Unknown Source:5427)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.get(Unknown Source:55)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3ab.get(:595754)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.A2M(Unknown Source:2376)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.get(Unknown Source:55)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3ab.get(:595754)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.A2M(Unknown Source:2502)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.get(Unknown Source:55)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3ab.get(:595754)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.A2M(Unknown Source:4071)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3aZ.get(Unknown Source:55)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.3ab.get(:595754)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at com.whatsapp.AbstractAppShellDelegate.onCreate(:483023)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.0xe.onCreate(:122826)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at X.1Dj.onCreate(:152041)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1122)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6619)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at android.app.ActivityThread.-wrap2(Unknown Source:0)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:108)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:166)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7529)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
08-25 16:11:17.357 17517 17517 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:921)

Thanks for your work! :)

[Schwartzblat]

Fixed. @jeverling @m00nty