SchwarzIT / node-red-chart

Node-red Helm Chart
Apache License 2.0
43 stars 28 forks source link

additional pod labels #130

Closed elihai-risk closed 2 years ago

elihai-risk commented 2 years ago

Is your feature request related to a problem? Please describe.

we want to have the ability to add more labels

Describe the solution you'd like

add here option to add more labels : https://github.com/SchwarzIT/node-red-chart/blob/main/charts/node-red/templates/deployment.yaml#L27

fo example: spec: metadata: labels: {{- if .Values.podLabels }} {{- toYaml .Values.podLabels | nindent 8 }} {{- end }}

Describe alternatives you've considered

don't have

Search

Code of Conduct

Additional context

No response

dirien commented 2 years ago

Hi @elihai-risk,

thanks for the feature idea! Yes ofc! I created a new release for this 0.18.0!

# -- Labels to add to the node-red pod. default: {}
podLabels: {}

Would love to hear your feedback, when you had time to test it!

Aviv-Jacobs commented 2 years ago

Hi, @dirien First of all - thanks for the quick work on the feature we asked. We need to configure the admin user in order to use the chart to upload flows automatically. It's not clear from the documentation how to configure the settings. should I just put the default settings with the changes I want under the settings section in the values.yaml file or should I create a config-map?

Thank you

dirien commented 2 years ago

Hi @Aviv-Jacobs,

thanks for your feedback! Yes we use a config map with the settings.js inside

settings:
  # name of the volume, free to use
  name: settings-js
  configMapName: settings-node-red-1

And the sidecar to refresh the flow, without the need to restart node-red.

  sidecar:
    enabled: true
    securityContext:
      runAsUser: 1000
    env:
      username: "operator"
      label: "node_red_flows"
      label_value: "node-red-1"

What I can offer to you is that we, @Kaktor and me, organise a little meeting and show you our setup here at the Schwarz Group! If you are interested, just drop me a mail engin.diri@mail.schwarz!

Aviv-Jacobs commented 2 years ago

@dirien thanks a lot for the quick answer and the willingness to help us. We may not need node-red at the end but if we do your help will be much appreciated

thank you!

dirien commented 2 years ago

@Aviv-Jacobs, awesome! Happy to help!