Missing curl in sidecar image

SchwarzIT / node-red-chart

Node-red Helm Chart

Apache License 2.0

43 stars 28 forks source link

Missing curl in sidecar image #149

Closed RasmusGodske closed 1 year ago

RasmusGodske commented 2 years ago

What happened?

flow_refresh.sh uses curl, however curl does not exist in sidecar image.

How can we reproduce this?

Enable sidecar in the values.yaml and provide nodered username and password.

Helm Chart version

0.20.0

Search

[X] I did search for other open and closed issues before opening this.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Additional context

No response

dirien commented 2 years ago

Hi @RasmusGodske,

thanks for raising the issue! Let me check if it makes sense to create a custom image wich contains curl and provide it as part of the helm this helm chart!

RasmusGodske commented 2 years ago

No worries, we did find a way around it by extending the image as seen here RasmusGodske/k8s-sidecar-curl-yq, and use that image instead for the sidecar.

However we did end up taking a completely different route, since the sidecar would fail to write to the flows.json file, after you have updated the flows through the node-red webui. We are not entirely sure why this happend, but after the node-red container updated the flows.json file the file would become read-only within the sidecar container.

dirien commented 2 years ago

@RasmusGodske I remember, that we had to set the user and group in the sidecar of the one from node-red! @Kaktor do you remember?

Otherwise I will look tomorrow into our code!

hinrichd commented 1 year ago

Just want to ask if this bug is still alive. Actually i run into the same issue. Missing curl and jq to run the flow refresh script inside the sidecar container. Using current helm chart with default sidecar from chart.