SchwarzIT / node-red-chart

Node-red Helm Chart
Apache License 2.0
40 stars 25 forks source link

Change indention for .Values.env to twelve #189

Closed tmiller closed 1 year ago

tmiller commented 1 year ago

In a prior commit the indention for env vars changed by adding an extra indent. Now when setting the following combinations the chart fails to render due to the indention levels of the environment variables being off by one:

  1. .Values.env and .Values.metrics.enabled == true
  2. .Values.sidecar.extraEnv and .Values.sidecar.enabled == true

This changes the indention from 10 to 12 for those two env settings which allows the chart to render

Signed-off-by: Thomas Miller git@me.tmiller.dev

Thank you for making node-red ⚙ better

Please reference the issue this PR is fixing.

Also verify you have:

dirien commented 1 year ago

Hi @tmiller

Thanks for the contribution! Can you do following points before I can merge your PR:

Thanks and awesome catch of the indentation! 👍

dirien commented 1 year ago

Hi @tmiller,

Thanks for the contribution. I checked the indents and fixed them in the deployment.yaml as the envs there where off. -> #207