Closed tmiller closed 1 year ago
Hi @tmiller
Thanks for the contribution! Can you do following points before I can merge your PR:
Signed the PR with git commit --amend --signoff
Update the version in the chart.yaml to 0.21.4
and add the reason for the change artifacthub.io/changes
Thanks and awesome catch of the indentation! 👍
Hi @tmiller,
Thanks for the contribution. I checked the indents and fixed them in the deployment.yaml
as the envs
there where off. -> #207
In a prior commit the indention for env vars changed by adding an extra indent. Now when setting the following combinations the chart fails to render due to the indention levels of the environment variables being off by one:
.Values.env
and.Values.metrics.enabled == true
.Values.sidecar.extraEnv
and.Values.sidecar.enabled == true
This changes the indention from 10 to 12 for those two env settings which allows the chart to render
Signed-off-by: Thomas Miller git@me.tmiller.dev
Thank you for making
node-red ⚙
betterPlease reference the issue this PR is fixing.
Also verify you have: