SchwarzIT / node-red-chart

Node-red Helm Chart
Apache License 2.0
36 stars 24 forks source link

Readiness for built-in https scheme support #246

Open mbaykara opened 1 year ago

mbaykara commented 1 year ago

What happened?

Let's consider a scenario where a Node-RED instance is configured with enabled https for some specific reason. In this case, the hard-enabled readiness check does not receive a 200 response because the scheme is set to http. As a result, the pod will not transition to the ready state.

How can we reproduce this?

To enhance the functionality, please consider the following revisions:

It appears that this chart has been designed for a specific use case and may no longer serve a general purpose.### Helm Chart version

0.24.1

Search

Code of Conduct

Additional context

No response

dirien commented 1 year ago

Hey @mbaykara,

thanks for the creating the issue and providing some valuable feedback.

Feel free start contributing your points into this codebase! This will help to make this chart an even better experience for the whole community.

On PR for each of your points would be great, as it is fast to review and incremental add new features!