SchwarzIT / node-red-chart

Node-red Helm Chart
Apache License 2.0
41 stars 26 forks source link

helmfile: Failed to render chart #258

Closed glenndehaan closed 1 year ago

glenndehaan commented 1 year ago

What happened?

When enabling the sidecar helmfile is unable to render the chart:

STDERR:
  Error: Failed to render chart: exit status 1: Error: unable to build kubernetes objects from release manifest: unable to decode "": json: cannot unmarshal number into Go struct field ObjectMeta.metadata.labels of type string
  Error: plugin "diff" exited with error

It looks like the default values won't work:

sidecar:
  enabled: true
  env:
    label: node-red-settings
    label_value: "1"

When changing the values to for example:

sidecar:
  enabled: true
  env:
    label: node-red-settings
    label_value: node-red-settings

This makes it work. So it seems like the quotes are not rendered correctly.

How can we reproduce this?

Use the following helmfile.yaml:

repositories:
  - name: node-red
    url: https://schwarzit.github.io/node-red-chart/

releases:
  - name: node-red
    namespace: node-red
    chart: node-red/node-red
    version: 0.24.2
    installed: true
    values:
      - values.yaml

And the following values.yaml:

settings:
  name: settings-config
  configMapName: settings-config

sidecar:
  enabled: true
  extraNodeModules:
    - node-red-contrib-microsoft-teams-tasks
    - node-red-contrib-json

When running helmfile apply this error will occur.

Helm Chart version

0.24.2

Search

Code of Conduct

Additional context

No response

dirien commented 1 year ago

Hey @glenndehaan, thanks for submitting the Issue. It's fixed wiht 0.24.4 of the Chart!

glenndehaan commented 1 year ago

Hi @dirien, I can confirm that this issue has been resolved by updating to 0.24.4 thank you!

dirien commented 1 year ago

@glenndehaan Awesome! Stay tuned for the other issue! Just need to fine tune the roles/rolebindings later!