SchwarzIT / node-red-chart

Node-red Helm Chart
Apache License 2.0
36 stars 24 forks source link

Implement computed annotations for #264

Closed dblencowe closed 11 months ago

dblencowe commented 11 months ago

Is your feature request related to a problem? Please describe.

In order to deploy this chart to my cluster successfully I need to add annotations to the service created

Describe the solution you'd like

Implement .Values.service.annotations in a fully backwards-compatible way

Describe alternatives you've considered

-

Search

Code of Conduct

Additional context

Happy to submit the PR for this if wanted

dirien commented 11 months ago

Hey @dblencowe,

thanks for reaching out and creating this improvement request.

I would love if you would contribute this to this chart.

dblencowe commented 11 months ago

Thanks Dirien! Really hope I got everything in the contributing guide right!

dirien commented 11 months ago

@dblencowe sure you are! Maybe you need to bump the version in the Chart.yaml

dblencowe commented 11 months ago

Sorry! Didn't realise I should do that in my PR. Updating now