SchwarzIT / onyx

🚀 A design system and Vue.js component library created by Schwarz IT
https://onyx.schwarz
Apache License 2.0
40 stars 4 forks source link

Fix missing types in storybook (OnyxSelect) #1365

Closed BoppLi closed 2 days ago

BoppLi commented 1 week ago

Task: try to get rid of "Omit" / "Pick", instead split up the types that are consumed. Example: OnyxSelectInputProps should be split so it can be used directly by OnyxSelect

dev storybook shows e.g. "readonly" not below "props" in OnyxSelect, is this a known issue? https://storybook.onyx.schwarz/?path=/story/components-select--readonly

Image

and if you open another example, it's totally gone.. https://storybook.onyx.schwarz/?path=/story/components-select--multiselect

Image

BoppLi commented 2 days ago

I found out that this is solved after removing "label" from OnyxSelectProps. It is already inherited from OnyxFormElementProps, so maybe because it was there twice, Storybook broke a bit?

=> do we still want to restructure the types?

reference PR: