search

SchwarzIT / onyx

🚀 A design system and Vue.js component library created by Schwarz IT
https://onyx.schwarz
Apache License 2.0
58 stars 5 forks source link

fix(CI): fix changed github user profile picture causing breaking CI screenshot tests #2105

Closed JoCa96 closed 1 week ago

JoCa96 commented 1 week ago

Root cause

The ComponentShowcase Vue component has some hardcoded example avatars, where the images are loaded from GitHub. The Screenshot tests fail because an avatar image on GitHub was updated, and therefore the saved screenshot doesn't match anymore.

Fix

This is fixed by intercepting the avatar image request in the screenshot test and always returning the same, static image. Closes #2106

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: d730b5c8b93246b8a9b36abc00775666f33d2118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR