SchwarzIT / onyx

🚀 A design system and Vue.js component library created by Schwarz IT
https://onyx.schwarz
Apache License 2.0
57 stars 6 forks source link

Implement OnyxListbox #564

Closed mj-hof closed 6 months ago

mj-hof commented 7 months ago

Why?

The flyout is a fundamental element utilized across various components such as dropdowns, navigation bars, paginations, tables, etc. It provides the users with the ability to open a small modal window, facilitating single or multisselection based on the context in which it is employed.

Design

Figma link

Acceptance criteria

Out of scope

Definition of Done

Review

Applicable ARIA Pattern

Listbox pattern

larsrickert commented 7 months ago

FYI, I removed multiselect, truncation and grouping in follow up tickets so I can close this before my vacation and another dev can continue working on it

jannick-ux commented 7 months ago

By default, the label should be hidden. Rest looks fine.

larsrickert commented 7 months ago

By default, the label should be hidden.

To be unify with the other components like input, checkbox, radio button and switch I would prefer to show it by default with a property to hide it. The label is required anyways for screen readers

jannick-ux commented 7 months ago

This label, that is used here, is not that kind of label, that has an important role to describe the purpose of the whole component. In the end this label here is just ment to give the possibility to write something like "items only referr to the date xx.xx.xxxx". So it is just a flexible hinttext/labeltext without any dependecy or importance to the whole component.

That's the reason why I would like to hide it in first place.

Was the description of the purpose understandable?