search

Schweinepriester / github-profile-achievements

A collection listing all Achievements available on the GitHub profile 🏆
MIT License
4.77k stars 450 forks source link

What happened to the 100% section? #30

Open seanpm2001 opened 2 years ago

seanpm2001 commented 2 years ago

The 100% section was a nice addition to the project. Why was it removed?

Schweinepriester commented 2 years ago

I mean technically it's still there: https://github.com/Schweinepriester/github-profile-achievements#100--samples The images as well, just not front and center.

The reason I've gone with the minimal version now is that those images are quite large. Which, for me, increased the load time noticeably while in my opinion not looking particular good in the table.

But:

  1. Thank you for noticing! :)
  2. Maybe I should change the link texts of the current sample links to make it more clear that they are leading to the live examples of the 100 % achievements?
  3. I was thinking about moving the "full" 100 % section including the images being displayed to its own markdown file, which wouldn't increase the README load time then, besides a link pointing there. What do you think?
  4. Also I made good progress today towards my ultimate goal to capture the 100 % achievements as SVGs, including the animation:
    (⚠ Currently they will look broken on github because of CORS. to see them proper you have to download them and then open in a browser)
    test2.svg & test6.svg
    I was prioritizing that ;)
seanpm2001 commented 2 years ago

I think moving them to their own file would be a good idea based on that reasoning. Thank you for the response.

Mirandaker3125 commented 2 years ago

Selam olsun