SchweizerischeBundesbahnen / netzgrafik-editor-frontend

The Netzgrafik-Editor is a powerful software that enables the creation, modification, and analysis of regular-interval timetable.
Other
22 stars 9 forks source link

[Feature request]: Asymmetric Times in Timetable Concepts #242

Open VXstone opened 1 month ago

VXstone commented 1 month ago

Preflight Checklist

Request type

Request for a new component

Functionality

Problem Statement: Currently, the Netzgrafik-Editor (NGE) does not support asymmetric times in timetable concepts. This limits the flexibility in editing and adjusting timetables. It also makes it very difficult to access existing productive timetable data or to import them. Therefore, the Netzgrafik-Editor should allow asymmetric times.

Proposed Solution: Implement a function that allows asymmetric times in timetable concepts. This function should be disabled by default but can be activated by the user. This should be saved within the variant, ensuring that a variant has a clearly defined state, i.e., whether asymmetry is allowed or not.

Functionality:

Saving Settings: The activation of asymmetric times, as well as the flag for warnings of asymmetric times, will be saved in the JSON of the variant. This ensures that the settings are retained for future edits.

Example JSON Implementation:

{  

   "metadata": { 
     "asymmetricTimes": false, 
    "warningAsymmetricTimes": true,   

   }
}

User Interface:

Technical Requirements:

Advantages:

Example Timetable 2024 Bild

Link to design proposal file

No response

aiAdrian commented 4 weeks ago

Thank you for the feature request regarding the implementation of asymmetric times in the Network Graphic Editor (NGE).

Proper justification

Due to the fundamental concept of the Netzgrafik-Editor, the feature request cannot be implemented as formulated. The concept of the Netzgrafik-Editor (Regular Interval Timetable) does not accommodate asymmetric times. The symmetry is fixed and cannot be adjusted without breaking the basic concept of the regular interval timetable. Furthermore, the zero-minute symmetry is defined as given in the Network Graphic Editor. Therefore, only times that are symmetrical to the zero minute can exist in the Netzgrafik-Editor (editing/processing/calculation, etc.).

Decision

Conclusion: The desired feature to support asymmetric times cannot be implemented as requested.

Alternative proposal

However, importing timetables from external systems with asymmetric times could be enabled through an import interface. It is necessary, though, that an exact transformation concept is available, detailing how the "erroneous" times can be quickly and easily found and manually corrected by the user, or how the times could potentially be automatically corrected.

A manual correction could be the first and simplest step in this process. If these times are to be edited with standard tools, it must be clearly indicated which times break the zero-minute symmetry. For this purpose, validation including a warning (orange) is available, meaning erroneous times are marked with a warning and rendered in orange. As long as not all times are correct, i.e., processed/corrected, side effects may occur. It is necessary to determine what this means. An analysis is required to identify what errors might occur if times are asymmetric. This is currently unclear. Therefore, a thorough analysis must be conducted before implementation to assess the potential impacts.