SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
51 stars 15 forks source link

976 improve the documentation of the ide secir model #1000

Closed lenaploetzke closed 2 months ago

lenaploetzke commented 2 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #976.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.34%. Comparing base (8ddb863) to head (0424b55). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1000 +/- ## ======================================= Coverage 96.34% 96.34% ======================================= Files 129 129 Lines 10056 10071 +15 ======================================= + Hits 9688 9703 +15 Misses 368 368 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lenaploetzke commented 2 months ago

I also think the formulas would be misplaced in the README. We should publish the paper instead and link it here :D For now, I think it's fine as it is.

I think we can also merge the PR before #952, the link should work if it's merged. Then we have already finished this PR, #952 will be finished soon.

annawendler commented 2 months ago

This looks great and can be merged after PR #952 has been merged.