SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
51 stars 15 forks source link

965 use int instead of unsigned int in lct infection state #1002

Closed lenaploetzke closed 2 months ago

lenaploetzke commented 2 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #965

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.34%. Comparing base (29cf76b) to head (d53a2f0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1002 +/- ## ========================================== - Coverage 96.34% 96.34% -0.01% ========================================== Files 129 129 Lines 10065 10064 -1 ========================================== - Hits 9697 9696 -1 Misses 368 368 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lenaploetzke commented 2 months ago

Looks good, but please check that all Ns are positive (non-negative?) - I think there is an assert for that, but please make sure.

Yes there was already a static_assert(((Ns > 0) && ...),) thing in line 43 of lct_infection_state.h for that because we actually need that the Ns are at least one.