Closed lenaploetzke closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.42%. Comparing base (
deefc27
) to head (92d7a37
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you merge the main branch so that the get_mean method is already included here?
Nice work!
I was wondering if we should rename ExponentialDecay to ExponentialSurvivalFunction. This would be consistent with the other new SAFs and describe better what it is used for. I'm not sure if SmootherCosineSurvivalFunction is a good name as I don't know if there is a name for the associated distribution, but I guess we should at least mention that this is a survival function as well in the documentation.
I like this idea and renamed ExponentialDecay. I also agree, that the name SmootherCosineSurvivalFunction is not appropriate, but put in the docu.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
-
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #929.