SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
51 stars 15 forks source link

897 new add initialization method from flows for lct model 1 #1005

Open lenaploetzke opened 2 months ago

lenaploetzke commented 2 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

-/-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #897.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.27%. Comparing base (d439941) to head (0181407).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1005 +/- ## ========================================== + Coverage 96.24% 96.27% +0.03% ========================================== Files 127 128 +1 Lines 10886 10992 +106 ========================================== + Hits 10477 10583 +106 Misses 409 409 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lenaploetzke commented 1 week ago

I was thinking that initializer_subcompartments might be a more suitable name than initializer_flows as you are calculating initial values of the subcompartments for given flows.

I do not think that initializer_subcompartments is a better name, because e.g. the realistic initialization also initializes subcompartments. The naming should include that we are using flows for initialization.

lenaploetzke commented 2 days ago

The LCT model has been updated in the meantime, so small changes had to be made here