HenrZu commented 1 month ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

The current code for the function export_input_data_county_timeseries is similar to the functionality in read_input_data_county.
This redundancy also increases the susceptibility to errors, as both codes always have to be maintained.
More unit tests for the extrapolation process

If need be, add additional information and what the reviewer should look out for in particular:

-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

[x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
[x] New code adheres to coding guidelines
[x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[x] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
[x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
[x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
[ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

[ ] Corresponding issue(s) is/are linked and addressed
[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
[ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.17%. Comparing base (9ee0b56) to head (5b81f94). Report is 3 commits behind head on main.

:exclamation: Current head 5b81f94 differs from pull request most recent head 7c48cd4

Please upload reports for the commit 7c48cd4 to get more accurate results.

Files	Patch %	Lines
cpp/models/ode_secirvvs/parameters_io.h	98.18%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1029 +/- ## ========================================== - Coverage 96.23% 96.17% -0.07% ========================================== Files 128 128 Lines 10867 10399 -468 ========================================== - Hits 10458 10001 -457 + Misses 409 398 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HenrZu commented 5 days ago

I have compared the runtime of the new extrapolation function with the old one. The results are almost identical. The result shown are for the secir model.

Num Days| 1 | 5 | 10 | 20 -- | -- | -- | -- | -- New Version | 30,3303 | 42,7880 | 58,3960 | 90,1510 Old Version | 29,3939 | 42,1209 | 57,7696 | 89,6838

SciCompMod / memilio

1028 Reduce export_input_data_county_timeseries #1029

Changes and Information

-

Merge Request - Guideline Checklist

Checks by code author

Checks by code reviewer(s)

Codecov Report