Open khoanguyen-dev opened 1 month ago
Attention: Patch coverage is 96.36364%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 96.23%. Comparing base (
575a146
) to head (ac874ab
). Report is 9 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
cpp/models/abm/world.cpp | 90.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I just noticed that the compliance vector looks very much like a parameter, especially with the getter/setter. We could think about putting it into a Person specific ParameterSet, as well as probably m_age or the random-group/hour variables; but probably in another PR.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1039 Closes #503