SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
52 stars 15 forks source link

992 download boost libs with URL instead of git repo #1048

Closed dabele closed 2 weeks ago

dabele commented 3 weeks ago

Changes and Information

Download boost libs from a URL instead of git repository, archive download is much faster. Removed the bootstrapping code. With this increased speed, a minimal boost version is not necessary and not worth the maintenance.

Results from CI: compile times (with ccache and boost URL download) are down to ~4 mins, before they were at 20+. Obviously depends on many ccache hits and misses there are.

Not using the URL from github (e.g. https://github.com/boostorg/boost/archive/refs/tags/boost-1.84.0.tar.gz) since those archives don't actually contain the source code. I think the archive generation is automated, but the boost repo requires more setup before it is complete (subrepos, bootstrapping).

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Closes #992

Checks by code author

Checks by code reviewer(s)

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.23%. Comparing base (2994f76) to head (bdde5c7). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1048 +/- ## ======================================= Coverage 96.23% 96.23% ======================================= Files 128 128 Lines 10852 10852 ======================================= Hits 10443 10443 Misses 409 409 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mknaranja commented 2 weeks ago

@reneSchm @dabele What's the time reduction for download itself?

@lenaploetzke just FYI :)

dabele commented 2 weeks ago

What's the time reduction for download itself?

archive download is a < 10 secs, git clone is 1-2 mins, rough estimate, I didn't measure exactly.