SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
51 stars 15 forks source link

892 implement simple lct model #915

Closed lenaploetzke closed 4 months ago

lenaploetzke commented 5 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #892.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6391c30) 95.88% compared to head (77afdda) 95.99%. Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #915 +/- ## ========================================== + Coverage 95.88% 95.99% +0.11% ========================================== Files 118 124 +6 Lines 9397 9674 +277 ========================================== + Hits 9010 9287 +277 Misses 387 387 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HenrZu commented 5 months ago

@mknaranja I think this PR can lead to issues with PR #894. Do we wait until this is merged?

mknaranja commented 5 months ago

@HenrZu @lenaploetzke We should advance both pull requests with review (and adaptations) at the same time and for the one to be merged later we should combine forces to not put to much on the shoulder of the persons who comes second ;)