SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
51 stars 15 forks source link

917 improve code coverage of ide secir #923

Closed lenaploetzke closed 3 months ago

lenaploetzke commented 5 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #917

lenaploetzke commented 5 months ago

The problem with the uncovered lines 227-230 in parameters.h was that there is a check for negative probabilities (210-214), so that the value -1 already leads to a returned true there.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d4cb5ee) 96.22% compared to head (6c42373) 96.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #923 +/- ## ========================================== + Coverage 96.22% 96.26% +0.04% ========================================== Files 124 124 Lines 9699 9699 ========================================== + Hits 9333 9337 +4 + Misses 366 362 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mknaranja commented 3 months ago

Merged with #959 .