SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
53 stars 16 forks source link

910 Handle pandas read excel engines #940

Closed patricklnz closed 6 months ago

patricklnz commented 7 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #910

patricklnz commented 6 months ago

Nice!

When executing getTestingData I get the following errors in line 55: With openpyxl: zipfile.BadZipFile: File is not a zip file With calamine: python_calamine.CalamineError: Cannot detect file format

Can you check if this has to do with the excel engine or if this is another issue (and open a new issue in that case)?

I opened a new Issue #981 and added the error handling.