Closed nijawa closed 3 months ago
I double checked for dangling references. Apparently, gcc 11 and clang 17 either do not care, or more probably fix them silently (dangling references cause undefined behaviour, so the compiler is technically allowed to do anything). However, gcc 13 does complain, and in both dynamic_npis.h
and mobility_io.h
we used to try and assign a Range r-value to a l-value reference. That is now fixed.
Attention: Patch coverage is 94.95413%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 96.33%. Comparing base (
ce75c58
) to head (baa026b
).
Files | Patch % | Lines |
---|---|---|
cpp/models/sde_sir/simulation.h | 86.48% | 5 Missing :warning: |
cpp/models/sde_sirs/simulation.h | 86.48% | 5 Missing :warning: |
cpp/memilio/io/mobility_io.h | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
-
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #953