SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
51 stars 15 forks source link

953 Implement basic stochastic equation based model #954

Closed nijawa closed 3 months ago

nijawa commented 4 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #953

reneSchm commented 3 months ago

I double checked for dangling references. Apparently, gcc 11 and clang 17 either do not care, or more probably fix them silently (dangling references cause undefined behaviour, so the compiler is technically allowed to do anything). However, gcc 13 does complain, and in both dynamic_npis.h and mobility_io.h we used to try and assign a Range r-value to a l-value reference. That is now fixed.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 94.95413% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 96.33%. Comparing base (ce75c58) to head (baa026b).

Files Patch % Lines
cpp/models/sde_sir/simulation.h 86.48% 5 Missing :warning:
cpp/models/sde_sirs/simulation.h 86.48% 5 Missing :warning:
cpp/memilio/io/mobility_io.h 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #954 +/- ## ========================================== - Coverage 96.36% 96.33% -0.03% ========================================== Files 123 129 +6 Lines 9844 10047 +203 ========================================== + Hits 9486 9679 +193 - Misses 358 368 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.