Closed annawendler closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.34%. Comparing base (
a5cbb91
) to head (59ffa22
). Report is 8 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I see the problem that m_transitions can be changed without confirming that the last value there matches the last value in m_populations. I can implement a setter where we would reset m_populations accordingly. Then m_populations should be set private, too, which would making setting S and R for the initialization of the solver a bit more tedious. I'm not sure if this is worth it or if it would be enough to add a constraint to the check_constraints function. Another possibility would be to set m_transitions private anyway without implementing getter and setter. Then we could define a friend class to set the initial flows based on real data or need to find another solution.
I see the problem that m_transitions can be changed without confirming that the last value there matches the last value in m_populations. I can implement a setter where we would reset m_populations accordingly. Then m_populations should be set private, too, which would making setting S and R for the initialization of the solver a bit more tedious. I'm not sure if this is worth it or if it would be enough to add a constraint to the check_constraints function. Another possibility would be to set m_transitions private anyway without implementing getter and setter. Then we could define a friend class to set the initial flows based on real data or need to find another solution.
We discussed this and agreed to stay with the public members and implement an additional check in the check_constraints() function.
Changes and Information
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #977