Open mknaranja opened 3 months ago
@HenrZu @jubicker After I had reseen our delay_lockdown
parameter on Thursday I directly made a first suggestion on how to improve it. There might be things missing like sampling, setting etc and tests are missing anyway. Could you have a look and take over?
Attention: Patch coverage is 99.50980%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 96.25%. Comparing base (
8f9a34c
) to head (da9d1fc
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
cpp/models/ode_secir/model.h | 96.29% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mknaranja @jubicker i have made some changes and added a few tests. Maybe one can verify/ review this further.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
-
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)