Closed dabele closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.23%. Comparing base (
575a146
) to head (5c47821
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dabele Who has been involved here and who is supposed to do the review?
@dabele Who has been involved here and who is supposed to do the review?
it's not done yet. but I need the CI to run for testing this, so it's not a draft.
A little off topic, but does this already help with the boost dependency, or do we need another solution for that? It currently takes up a lot of CI time, both for the download itself as well as for packing and transferring artifacts, as these pack the entire build directory.
Sadly, this doesn't help with that. I though about caching boost, but this would only be possible if the same bootstrapped boost is usable by all builds (or at least all builds of the same operating system family). boost is more than 1G, so if every build needs it's own cached version this will exceed the limit. This will only help with the download and bootstrap phase of boost, not sure what could be done about the artifact size. I guess only saving artifacts that are really required, i.e. test executables and shared objects.
Changes and Information
To see that the cache is working correctly:
Closes #305
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)