Closed reneSchm closed 2 months ago
Attention: Patch coverage is 86.66667%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 96.34%. Comparing base (
f5e415a
) to head (14cb794
).
Files | Patch % | Lines |
---|---|---|
cpp/memilio/math/integrator.cpp | 77.77% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@reneSchm Thanks for the nice fix and the additional work on float comparison operators. Good job.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
dt == dt_max
while the ODE admits a larger step size.i
. I you prefer the while loop for any reason, I will undo this change.floating_point_less_equal
returned!floating_point_less
and corrected it to!floating_point_greater
.Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #988