SciCompMod / memilio

Modular spatio-temporal models for epidemic and pandemic simulations
https://scicompmod.github.io/memilio/
Apache License 2.0
51 stars 15 forks source link

988 info on sucessful adaptive step sizing is also shown for fixed step size integrators #996

Closed reneSchm closed 2 months ago

reneSchm commented 2 months ago

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

Checks by code reviewer(s)

Closes #988

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.34%. Comparing base (f5e415a) to head (14cb794).

Files Patch % Lines
cpp/memilio/math/integrator.cpp 77.77% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #996 +/- ## ======================================= Coverage 96.34% 96.34% ======================================= Files 129 129 Lines 10058 10065 +7 ======================================= + Hits 9690 9697 +7 Misses 368 368 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mknaranja commented 2 months ago

@reneSchm Thanks for the nice fix and the additional work on float comparison operators. Good job.