search

SciFin-Team / SciFin

SciFin is a python package for Science & Finance.
MIT License
12 stars 7 forks source link

DevOps practice #9

Open godfrey-leung opened 4 years ago

godfrey-leung commented 4 years ago

https://github.com/SciFin-Team/SciFin/blob/0dbda70925492ee988ebac2c1c38c4d112e85570/scifin/classifier/classifier.py#L122

better convert this to a class instead of a function that returns a tuple of several objects in that way, it is much easier and convenient to add, modify and test it when developing the package

FabienNugier commented 4 years ago

Thanks Godfrey! Indeed, a class would be a good way. We are thinking of integrating this function with some others in a consistent manner.