search

SciGraph / golr-loader

Convert SciGraph queries into json that can be loaded by Golr
Apache License 2.0
1 stars 3 forks source link

Consider aligning getNeighbors and getClosure methods #22

Closed kshefchek closed 7 years ago

kshefchek commented 7 years ago

We use depthFirst() when generating a closure for an ID; however, the we should consider using breadthFirst() instead to get the full set of classes.

See https://github.com/SciGraph/golr-loader/blob/1f3c4afcc36f91de3440e4b2c7b3e2167b0fcae2/src/main/java/org/monarch/golr/ClosureUtil.java#L89

vs.

https://github.com/SciGraph/SciGraph/blob/8e46c9682e7bdfb6afbd5e1bde830bee2a745db7/SciGraph-core/src/main/java/io/scigraph/internal/GraphApi.java#L84