search

SciGraph / golr-loader

Convert SciGraph queries into json that can be loaded by Golr
Apache License 2.0
1 stars 3 forks source link

Added missing dependency for testcases and java9 support in pom.xml #39

Closed yy20716 closed 6 years ago

yy20716 commented 6 years ago

  1. I tested the branch in Kent's PR but still failed to compile; the main package was fine but the test package had issues. 

    [INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/yy20716/eclipse-workspace/golr-loader/src/test/java/org/monarch/golr/GolrLoadSetup.java:[112,5] cannot access org.neo4j.test.rule.ExternalResource
class file for org.neo4j.test.rule.ExternalResource not found
[INFO] 1 error

    Based on the other Kent's commit, I added a dependency entry in pom.xml to solve that error.

  2. I also added Java 9 entry, i.e. I was using Java 9 but the previous pom.xml did not have the entry for java 9, so simply added the entry to run codes.

kshefchek commented 6 years ago

Thanks! +1