SciKit-Surgery / scikit-surgery

SciKit-Surgery - Compact Libraries for Surgical Navigation
http://scikit-surgery.github.io/scikit-surgery/
Other
39 stars 11 forks source link

Move scikit projects to the SNAPPY group #24

Closed thompson318 closed 4 years ago

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 16, 2018, 13:32

All of the repositories that are ready for wider circulation/publicising should be organised within a group for convenience.

https://weisslab.cs.ucl.ac.uk/WEISS/SoftwareRepositories/SNAPPY

Projects that aren't ready can stay in their own repository.

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Nov 26, 2018, 09:30

If you move to group, be sure to update WIKI page accordingly, and .... will this break gitlab triggers for read the docs? What about location on PyPi.

We should sort this out sooner rather than later, so we don't proliferate these things once we widely publicise stuff.

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 26, 2018, 09:36

assigned to @ThomasDowrick

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 26, 2018, 09:37

Good questions - before I move any of the proper repos, I will create a dummy repo and then move it, to see what breaks.

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 26, 2018, 13:02

So I've tried it out and have identified the following things that need updating after moving a repository:

PyPI is unaffected.

Steps

  1. Commit and local changes.

  2. Move the repository to the SoftwareRepositories/SNAPPY group:

    • Open the repository in Gitlab, go to Settings -> General -> Advanced -> Transfer project. image
  3. Delete your local copy and reclone the repository.

  4. Replace any references to the original repository (e.g. WEISS/SoftwareRepositories/scikitXYZ/) with the new one (WEISS/SoftwareRepositories/SNAPPY/scikitXYZ). From a shell in the root dir of the repository, the following command will handle this:

grep -l "Repositories/sci" *.* .gitlab-ci.yml | xargs sed -i 's|Repositories/sci|Repositories/SNAPPY/sci|g'
  1. push these changes.

  2. Update ReadTheDocs - Go to the project's settings in ReadTheDocs, and update the repository URL and the project homepage to the new one.

  3. Update the SNAPPY Wiki page

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 26, 2018, 13:06

I will move one of the actual repositories this afternoon, and double check all is well.

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 26, 2018, 15:36

I have moved scikit-surgery into the SNAPPY group using the above instructions, nothing else was needed.

The PyPI deploy step works fine and ReadTheDocs webhooks remain unchanged, only the repo url needs to be updated.

I will move scikit-surgery image and overlay. @MattClarkson @StephenThompson can you give it a go with a different repository, to check that my instructions are OK?

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Nov 26, 2018, 15:57

@TomDoel, I'll do scikit-surgerycore, @StephenThompson can do nditracker when he's ready i guess.

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 26, 2018, 16:19

@MattClarkson - did you setup ReadTheDocs for surgeryimage? I don't have it on my account. If so, can you update the proejct urls?

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Nov 26, 2018, 19:13

I did, I'll sort it tonight.

Also - we could add the new location to PythonTemplate otherwise, it won't automatically generate the right paths?

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Nov 26, 2018, 20:52

scikit-surgerycore and scikit-surgeryvideolag moved.

Just scikit-surgerynditracker to go, and updating PythonTemplate.

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Nov 27, 2018, 08:58

What I had in mind was that only projects that are reasonably ready (i.e. working and documented) get moved into the SNAPPY group. Thus if someone is searching for a project in SNAPPY, they can be sure that it works. Hence I am not planning to move surgerynditracker yet. That being the case we may not want the Python Template to default to SNAPPY. Maybe that's just making unnecessary work for us though.

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Nov 27, 2018, 09:05

Agree, don't move until you are ready.

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 27, 2018, 10:19

I've added SNAPPY as a (non-default) option in PythonTemplate.

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Nov 28, 2018, 07:42

So this is done right? Steve can move his when ready?

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 28, 2018, 08:16

Yes, everything is in the right place for now.

thompson318 commented 4 years ago

In GitLab by @ThomasDowrick on Nov 28, 2018, 08:16

closed