Push scikit-surgerycore to PyPi, so scikit-surgeryXXX can depend on it, and adopt semantic versioning. #28

Closed thompson318 closed 4 years ago

In GitLab by @MattClarkson on Nov 28, 2018, 08:42

(Possibly a bit wierd asking this as an Issue).

Short version: I presume we are ok with scikit-surgeryXXX depending on scikit-surgerycore?

Long version: Where do we put small utility functions? Im seeing a few in scikit-surgeryimage that could well go in scikit-surgerycore, but then we would need to have proper semantic versioning of scikit-surgerycore, and releases set up on PyPi, so that we can ensure that scikit-surgeryimage loads the right version.

If we agree, then we should ensure scikit-surgerycore is up on PyPi, and initiate that now?

(Note to Tom, without me using a 'mention' - when I assign this to you, do you get automatically emailed?)

@StephenThompson - cc'd as well?

In GitLab by @ThomasDowrick on Nov 28, 2018, 08:49

I do get the notification, yes.

I agree that utility functions should be kept in core where possible. I will take a look at moving the ones from image today.

In GitLab by @MattClarkson on Nov 28, 2018, 09:01

OK. Then this ticket should essentially be "ensure scikit-surgerycore is on PyPi and semantic versioning adopted". Ive updated the title.

In GitLab by @MattClarkson on Nov 28, 2018, 09:08

changed title from {-Remind me - scikit-surgeryXXX depends on scikit-surgerycore?-} to {+Push scikit-surgerycore to PyPi, so scikit-surgeryXXX can depend on it, and adopt semantic versioning.+}

In GitLab by @StephenThompson on Nov 28, 2018, 09:13

I also agree that this is the way to do things.

In GitLab by @MattClarkson on Nov 28, 2018, 09:16

Cool. Rock on.

In GitLab by @ThomasDowrick on Nov 28, 2018, 10:39

core is now on PyPI - https://pypi.org/project/scikit-surgerycore/ (version 0.0.1).

This has brought a few other issues to my attention, which I will raise separate issue for and try and sort today as well:

We should update the readme.rst for projects that are on PyPI to remove/edit the following bit:


You can pip install directly from the repository as follows:

    pip install git+https://weisslab.cs.ucl.ac.uk/WEISS/SoftwareRepositories/SNAPPY/scikit-surgerycore

Update the scikit-surgery repository so that it install other the core and image packages.

In GitLab by @ThomasDowrick on Nov 28, 2018, 10:39

closed

In GitLab by @ThomasDowrick on Dec 3, 2018, 09:19

I decided against moving the existing utility functions from image to core, as they have an opencv dependency.

SciKit-Surgery / scikit-surgery

Push scikit-surgerycore to PyPi, so scikit-surgeryXXX can depend on it, and adopt semantic versioning. #28