SciKit-Surgery / scikit-surgery

SciKit-Surgery - Compact Libraries for Surgical Navigation
http://scikit-surgery.github.io/scikit-surgery/
Other
39 stars 11 forks source link

Where did pillow dependency come from. #34

Closed thompson318 closed 4 years ago

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Dec 10, 2018, 09:53

PythonTemplate and hence some of our packages to date have a dependency on pillow.

While we may need it for some derived projects, I don't imagine we need it for all projects? Especially if OpenCV is our go-to image format.

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Dec 13, 2018, 09:36

@StephenThompson @ThomasDowrick @TomDoel - any ideas where this came from?

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Dec 13, 2018, 09:41

Looks like a mistake to me. It only turns up in the setup.py. Unless one of the Toms comes back with something I'd just delete it.

thompson318 commented 4 years ago

In GitLab by @TomDoel on Dec 13, 2018, 11:08

Yes, I'm pretty sure you can delete it.

I developed the packaging code on a different project that did require pillow, and I probably forgotten to remove the dependency when I transferred the code to setup.py (commit 531c06).

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Dec 13, 2018, 11:31

Thanks Tom, I've removed pillow from setup.py.

thompson318 commented 4 years ago

In GitLab by @StephenThompson on Dec 13, 2018, 11:31

closed