search

SciKit-Surgery / scikit-surgery

SciKit-Surgery - Compact Libraries for Surgical Navigation
http://scikit-surgery.github.io/scikit-surgery/
Other
39 stars 11 forks source link

In PythonTemplate, should lint be done in a separate environment? #38

Closed thompson318 closed 4 years ago

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Dec 21, 2018, 17:03

On windows setting up a new environment takes significantly longer than Linux and Mac.

Is it necessary just for linting?

@TomDoel, @ThomasDowrick, @StephenThompson - any reason why its like this?

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Dec 21, 2018, 23:06

changed title from {-S-}hould lint be done in a separate environment? to {+In PythonTemplate, s+}hould lint be done in a separate environment?

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Dec 21, 2018, 23:06

moved from WEISS/SoftwareRepositories/PythonTemplate#35

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Dec 22, 2018, 06:54

I came to the conclusion "yes" it should be in a separate virtualenv.

If you put pylint in with say py27, then someone else decides you dont need py27, they would probably edit tox.ini, and before long pylint would not run, or people would forget about it.

Best keep them all separate, as its safer in the long run.

thompson318 commented 4 years ago

In GitLab by @MattClarkson on Dec 22, 2018, 06:54

closed

thompson318 commented 4 years ago

In GitLab by @TomDoel on Dec 22, 2018, 10:28

Also makes it a bit clearer whether errors are caused by the tests or linting, and also allows you to invoke listing or tests separately using ‘tox -e lint’ or similar (useful for local development, say you’re fixing linting problems and don’t want to keep running the tests).